fix: anonymous props that's not moved to sensitive props

[NicolasMassart]

Description

Add a legacy compatible process in the addProperties function to handle the object props that contains a anonymous: true and move them to sensitiveProperties instead.

It was planned that code would use addSensistive properties, but sometimes, we get some mixed props from places like a getAnalyticsParams function that returns a lot props and passes them along far before the event is built.
It would require a too big refactoring to split these props at the source.
I decided to add a new processing in the addProperties directly to filter anonymous props passed as normal props and redirect them.

Even if this new additional processing is executed for all the addProperties calls, it is not adding enough processing time to negatively impact performances.

Related issues

Fixes #12728

Manual testing steps

1. View the tx approval screen
2. check Approval Started event props
3. generates both a non-anonymous and an anonymous event.
4. Only anonymous event contains number_tokens_requested

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 62a620d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4ffb17ac-d155-43d1-ac3d-5ba01cd47b15

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud