-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix send
flow deeplinks
#12965
fix: Fix send
flow deeplinks
#12965
Conversation
Quality Gate passedIssues Measures |
Deeplink opens correct send flow screen on iOS: Bitrise build https://app.bitrise.io/build/2a9d2382-e406-41b7-82dc-22de573091fb?tab=artifacts ScreenRecording_01-13-2025.18-12-22_1.MP4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
The related test file only has a single snapshot test. Since we plan to update this confirmation to a redesign confirmation, I think it's fine not including a test now
Bitrise build (Android release) https://app.bitrise.io/build/5fad22ac-97be-4459-b9ea-21eb51b2580b?tab=artifacts Fix doesn't work on Android, clicking on the link opens MM app but doesn't start the Send flow: android.mp4 |
Bitrise build (Android release)
fix.not.working-.click.on.deeplink.movfix.working.-.scan.QR.mov |
@Unik0rnMaggie thanks for taking a look at this. There should be no discrepancy between iOS and Android because fix is purely setting a forgotten argument in JS context. Also this was the PR that we introduce that bug: #12321 |
Hi @OGPoyraz sure, glad to help! And apologies for the poor resolution. Here is another video: I'm using the same payment link for both actions:
Same.payment.link.movPlease let me know if you need anything else! Thank you! |
Thanks a lot @Unik0rnMaggie, it seems like both are the same links, weird. By the way just an info for you, if we are purely testing deeplinks, we should scan that QR code with your camera app, not the QR scanner in the MM app, because they are not the same flow. |
Hi @OGPoyraz thank you very much! And duly noted! I will keep this in mind for future testing! I tested again using the device camera to scan the QR code and it's the same behavior as when clicking on the deep link: Nothing happens and the send flow is not starting fix.not.working.mov |
Marking this PR as |
Description
This PR aims to fix deeplinks using
Send
flow.Related issues
Fixes: #12689
Manual testing steps
Screenshots/Recordings
Simulator.Screen.Recording.-.iPhone.13.Pro.-.2025-01-13.at.22.01.50.mp4
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist