Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: amount space crash #1372

Merged
merged 2 commits into from
Feb 19, 2020
Merged

bugfix: amount space crash #1372

merged 2 commits into from
Feb 19, 2020

Conversation

estebanmino
Copy link
Contributor

Description

Fixes #1341

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Feb 14, 2020
danjm
danjm approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Are there any other possible inputs we should be validating against? For examples letters, or multiple decimal points (e.g. 1....05 or 1.0.0.0.5)?

@estebanmino
Copy link
Contributor Author

@danjm yes, we validate those with the use of isDecimal which ignores spaces, that's why it was failing

ibrahimtaveras00
ibrahimtaveras00 approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both OS's on both old flow send view and instapay, QA Passed 👍

@estebanmino estebanmino merged commit 7c190af into develop Feb 19, 2020
@whymarrh whymarrh deleted the bugfix/amount-space-crash branch March 19, 2020 03:07
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix: amount space crash (#1372)
67f38dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@danjm danjm danjm approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in old send flow + InstaPay send when using space on keyboard
4 participants
@estebanmino @rickycodes @danjm @ibrahimtaveras00