Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: ios close icon #1410

Merged
merged 2 commits into from
Mar 10, 2020
Merged

bugfix: ios close icon #1410

merged 2 commits into from
Mar 10, 2020

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Mar 10, 2020 •
edited
Loading

Description

before

image

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Mar 10, 2020
rickycodes
rickycodes approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@rickycodes rickycodes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

was this always like this or a regression based on recent changes?

@estebanmino
Copy link
Contributor Author

@rickycodes I thought it could be related to the padding changes on the navbar but it didn't seem like that was the reason

ibrahimtaveras00
ibrahimtaveras00 approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good on both OS's on multiple screens, QA Passed 👍

@estebanmino estebanmino merged commit 4877fd9 into develop Mar 10, 2020
@whymarrh whymarrh deleted the bugfix/ios-close-icon branch March 19, 2020 03:07
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix: ios close icon (#1410)
e3a5434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @rickycodes @ibrahimtaveras00