Use setTimeout hack to get paste context back #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
added
the
needs-qa
|
actually, this is going to update the whole view twice because we have two |
|
@estebanmino I didn't, but I will try that and if it works I will update the PR :) |
|
@estebanmino yep, that worked! Just updated :) |
danjm-temp
approved these changes
Mar 24, 2020
ibrahimtaveras00
approved these changes
Mar 24, 2020
Super weird workaround that I found here: facebook/react-native#23653 (comment)
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Use setTimeout hack to get paste context back Super weird workaround that I found here: facebook/react-native#23653 (comment) * Move everything into a single setState call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
super weird workaround that I found here: facebook/react-native#23653 (comment). that issue is for
multiline, but it appears to work here none the less.looking at the existing code a little bit more closely and I see a link to this: facebook/react-native#9958. (@estebanmino it appears we ran into the same problem before?) if you look at the hack outlined, they actually used a
setTimeout... It doesn't seem to work unless the width is reset a little later.Before (paste context does not appear on Rinkeby):
After:
Checklist
Issue
Resolves #1442