Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Sentry upload during iOS Debug build #1458

Merged
merged 2 commits into from
Mar 25, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Mar 24, 2020

This step is already skipped during the Android debug build.

This ensures a local develop build will work correctly without a Sentry auth token. This was implemented incorrectly in #1376

This step is already skipped during the Android debug build
@Gudahtt Gudahtt mentioned this pull request Mar 24, 2020
3 tasks
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Member Author

Gudahtt commented Mar 25, 2020

@estebanmino has confirmed on Slack that this fixes the debug build at least. We should still confirm that the release build uploads sourcemaps properly, but I doubt that the CONFIGURATION environment variable would be set to Debug for a release build, so... this probably works.

@Gudahtt Gudahtt merged commit 1ba5141 into develop Mar 25, 2020
@Gudahtt Gudahtt deleted the skip-sentry-upload-in-debug-mode branch March 25, 2020 15:32
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
This step is already skipped during the Android debug build

Co-authored-by: Erik Marks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants