Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detox: Update dapp initiated txn file #1477

Merged
merged 3 commits into from
Apr 9, 2020

Conversation

ibrahimtaveras00
Copy link
Contributor

This PR fixes this test, dapp-initiated-txn.spec.js, due to changes from both the site itself (location of CTA's changed on the x and y axis) and feature update (removing success screen)

Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ibrahimtaveras00 ibrahimtaveras00 merged commit 468cccd into develop Apr 9, 2020
@ibrahimtaveras00 ibrahimtaveras00 deleted the detox/update-dapp-txn-file branch April 9, 2020 20:32
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants