Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

MetaMask / metamask-mobile Public

Notifications You must be signed in to change notification settings
Fork 1.2k
Star 2.2k

Code
Issues 1k
Pull requests 128
Actions
Projects 1
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Dapp Transaction Confirmation Re-designs#1559

Merged

EtDu merged 54 commits intodevelopMetaMask/metamask-mobile:developfrom dapp-confirmation-designsMetaMask/metamask-mobile:dapp-confirmation-designsCopy head branch name to clipboard

Jul 7, 2020

+1,303-1,538

Conversation Commits54 (54)Checks Files changed

Commits

Commits on Jul 5, 2020

Nav/Main: dappTransactionModalVisible in state & toggleDappTransactionModal function, render Approve directly instead of using navigation
EtDu
committed
Approval: stop using navigation API, instead hide or show the modal. Render a modal with TransactionEditor & TransactionHeader, getUrlFromBrowser helper added for TransactionHeader
EtDu
committed
TransactionEditor: use react fragment in place of view, remove styles
EtDu
committed
Approval: move out TransactionHeader and root style
EtDu
committed
TransactionEditor: move in root styles, different for txEdit and txReview
EtDu
committed
TransactionReview: Use TransactionHeader, remove ActionView
EtDu
committed
TransactionReviewSummary: use WarningMessage component
EtDu
committed
TransactionReviewSummary: styling for function indicator and amount summary
EtDu
committed
TransactionReviewSummary: remove flex style, fix paddings
EtDu
committed
TransactionReview: use AccountInfoCard
EtDu
committed
Fix merge glitches
EtDu
committed
TransactionReview: take state and functionality from TransactionReviewSummary, pass props
EtDu
committed
TransactionReviewFeeCard: use padding instead of width percentage
EtDu
committed
TransactionReview: remove renderTransactionDetails, render TransactionReviewInformation directly
EtDu
committed
TransactionReviewSummary: fix proptypes
EtDu
committed
TransactionReviewInformation: remove overview style, fix styles for error, add assetAmount, fiatValue & primaryCurrency props, render TransactionReviewFeeCard
EtDu
committed
TransactionReviewInformation: add View Data button
EtDu
committed
TransactionReview: toggleDataView & dataVisible in state, render review info if dataVisible false, else render empty view for now
EtDu
committed
TransactionReview: change toggleDataView to arrow fn
EtDu
committed
Locales: add transaction.view_data
EtDu
committed
TransactionReviewInformation: fix touch area for view data button
EtDu
committed
TransactionReview: re-add ActionView, fix it's height based on screen size, fix error message
EtDu
committed
TransactionEditor: ensure dynamic modal height
EtDu
committed
Locales: add review_data, data, review_function
EtDu
committed
TransactionReviewData: implement design, use toggleDataView from props to go back
EtDu
committed
TransactionReview: use TransactionReviewData, pass toggleDataView to props
EtDu
committed
TransactionEdit: strip down, remove everything and render CustomGas with props
EtDu
committed
UI/CustomGas: fix styling + logic to mimic SendFlow/CustomGas, only handle selector gas price change upon clicking save, use renderGasError
EtDu
committed
CustomGas: fix loader
EtDu
committed
SendFlow/CustomGas: Add comment for fix in transaction-components
EtDu
committed
locales: add custom_gas.total
EtDu
committed
UI/CustomGas: use local error validation, only handle gas fee on save button press
EtDu
committed
snapshot/test updates
EtDu
committed
Approval: fix lint error
EtDu
committed
TransactionReviewSummary: change primary value based on primary currency
EtDu
committed
TransactionReview: pass props to TransactionReviewSummary
EtDu
committed
snapshots & tests
EtDu
committed
UI/CustomGas: fix custom gas selector button locking if initial NSF error
EtDu
committed
snapshot
EtDu
committed
TransactionEdit: can change mode to review even if gas error (namely ISF), unlocks going back from custom gas modals if error is present
EtDu
committed
snapshot gravy
EtDu
committed
Feedback updates
EtDu
committed
Design fixes
EtDu
committed
locales: change data description text
EtDu
committed
snapshot
EtDu
committed
TransactionReviewData: add Hex data title
EtDu
committed
locales: change hex data
EtDu
committed
snapshot update yo
EtDu
committed
CustomGas: remove redundant setstate calls
EtDu
committed
TransactionReview: tweak style of hex data and add bold text
EtDu
committed
TransactionReviewFeeCard: fix rendering problem with ERC20 tokens, total value now passed down as view or text component
EtDu
committed
snapshot updatessss
EtDu
committed
Send, Nav/Main: move toggleDappTransactionModal & dappTransactionModalVisible to redux, use in Send to close dapp tx modal (if it's open) to fix send deeplink tx data getting wiped
EtDu
committed
Fix stubborn tab/spacing lint error
EtDu
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.