-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React native upgrade 0.62.2 rebased #1586
Merged
Merged
Changes from 28 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
483c9dc
all files changed
andrepimenta 2cf16e9
init Pods
andrepimenta ce7791d
pods working
andrepimenta 9893fbc
app running
andrepimenta 61ee331
fixed native and metro problems
andrepimenta adbd785
fix pods deployment target
andrepimenta a52d8f3
android running but with RN errors
andrepimenta 872d0a7
viewpager working
andrepimenta c64e59a
fixed our custom webview
andrepimenta b4609c3
Fix RCTAnalytics
andrepimenta be47c7a
lint [IMPORTANT]
andrepimenta 3e1b7ff
fix warnings & gesture handler
andrepimenta c8b47f9
update scritps and readme
andrepimenta a4a3920
fix most tests
andrepimenta e4820e5
tests working
andrepimenta a7f9d54
fix TouchableHighlight tests
andrepimenta 0d36222
rebased
andrepimenta d80e5b3
return to correct pod platform version
andrepimenta 88efcb4
Upgrade to RN 0.62.2
andrepimenta 9576ca2
Fix detox
andrepimenta dc08b85
fix format
andrepimenta d86df51
fix metro server start
andrepimenta 6582a8f
fix bitcode error
andrepimenta 3e9eb07
fix e2e release ios
andrepimenta d111f27
returning to previous deployment target
andrepimenta 0bb849d
detox bump
andrepimenta 46cfc3a
fix yarn clean
andrepimenta dcbe6e7
Create react-native-scrollable-tab-view+1.0.0.patch
andrepimenta f5e18d3
Back to 11.0 deployment target and fix sentry properties
andrepimenta a518263
Allow more memory for daemon
andrepimenta 89dcf6d
Fixed end of file warnings
andrepimenta 0e9d979
remove extra space
andrepimenta 35bda39
Fix for e2e tests
andrepimenta 7f8916c
Ignore VirtualizedLists warning
andrepimenta 51c265f
Merge branch 'develop' into react-native-upgrade-0.62.1-rebased
andrepimenta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| module.exports = { | ||
| root: true, | ||
| parser: 'babel-eslint', | ||
| extends: ['@react-native-community', 'eslint:recommended', 'plugin:import/warnings', 'plugin:react/recommended'], | ||
| globals: { | ||
| process: true, | ||
| beforeAll: true, | ||
| afterAll: true, | ||
| describe: true, | ||
| expect: true, | ||
| it: true, | ||
| jasmine: true, | ||
| jest: true, | ||
| spyOn: true, | ||
| element: true, | ||
| by: true, | ||
| beforeEach: true, | ||
| device: true, | ||
| waitFor: true, | ||
| __DEV__: true | ||
| }, | ||
| rules: { | ||
| 'no-catch-shadow': 0, | ||
| 'no-console': ['warn', { allow: ['warn', 'error'] }], | ||
| quotes: [ | ||
| 'error', | ||
| 'single', | ||
| { | ||
| avoidEscape: true, | ||
| allowTemplateLiterals: true | ||
| } | ||
| ], | ||
| 'comma-dangle': 0, | ||
| curly: 0, | ||
| 'no-shadow': 0, | ||
| 'no-bitwise': 0, | ||
| 'class-methods-use-this': 0, | ||
| 'eol-last': 1, | ||
| 'import/no-named-as-default': 0, | ||
| 'no-invalid-this': 0, | ||
| 'no-new': 0, | ||
| 'react/jsx-handler-names': 0, | ||
| 'react/no-did-mount-set-state': 0, | ||
| 'react/prefer-stateless-function': 0, | ||
| 'require-atomic-updates': 0, | ||
| 'array-callback-return': 2, | ||
| 'arrow-body-style': 2, | ||
| 'dot-notation': 2, | ||
| eqeqeq: 2, | ||
| 'import/no-amd': 2, | ||
| 'import/no-commonjs': 2, | ||
| 'import/no-duplicates': 2, | ||
| 'import/no-extraneous-dependencies': 2, | ||
| 'import/no-mutable-exports': 2, | ||
| 'import/no-namespace': 2, | ||
| 'import/no-nodejs-modules': 2, | ||
| 'import/prefer-default-export': 2, | ||
| 'no-alert': 2, | ||
| 'no-constant-condition': [ | ||
| 2, | ||
| { | ||
| checkLoops: false | ||
| } | ||
| ], | ||
| 'no-duplicate-imports': 2, | ||
| 'no-empty-function': 2, | ||
| 'no-else-return': 2, | ||
| 'no-eval': 2, | ||
| 'no-extend-native': 2, | ||
| 'no-extra-bind': 2, | ||
| 'no-global-assign': 2, | ||
| 'no-implicit-globals': 2, | ||
| 'no-implied-eval': 2, | ||
| 'no-lonely-if': 2, | ||
| 'no-loop-func': 2, | ||
| 'no-new-func': 2, | ||
| 'no-new-wrappers': 2, | ||
| 'no-proto': 2, | ||
| 'no-script-url': 2, | ||
| 'no-self-compare': 2, | ||
| 'no-throw-literal': 2, | ||
| 'no-unmodified-loop-condition': 2, | ||
| 'no-unneeded-ternary': [ | ||
| 2, | ||
| { | ||
| defaultAssignment: false | ||
| } | ||
| ], | ||
| 'no-unsafe-negation': 2, | ||
| 'no-unused-expressions': [ | ||
| 2, | ||
| { | ||
| allowTernary: true, | ||
| allowShortCircuit: true | ||
| } | ||
| ], | ||
| 'no-use-before-define': [2, 'nofunc'], | ||
| 'no-useless-call': 2, | ||
| 'no-useless-computed-key': 2, | ||
| 'no-useless-concat': 2, | ||
| 'no-useless-constructor': 2, | ||
| 'no-useless-rename': 2, | ||
| 'no-var': 2, | ||
| 'no-with': 2, | ||
| 'object-shorthand': 2, | ||
| 'operator-assignment': 2, | ||
| 'prefer-arrow-callback': 2, | ||
| 'prefer-const': 2, | ||
| 'prefer-rest-params': 2, | ||
| 'prefer-spread': 2, | ||
| 'import/no-unresolved': 2, | ||
| 'eslint-comments/no-unlimited-disable': 0, | ||
| 'eslint-comments/no-unused-disable': 0, | ||
| 'react-native/no-color-literals': 2, | ||
| 'react-native/no-inline-styles': 2, | ||
| 'react-native/no-unused-styles': 2, | ||
| 'react-native/split-platform-components': 2, | ||
| 'react/jsx-boolean-value': 2, | ||
| 'react/jsx-key': 1, | ||
| 'react/jsx-no-bind': 1, | ||
| 'react/jsx-pascal-case': 2, | ||
| 'react/jsx-wrap-multilines': 2, | ||
| 'react/no-danger': 2, | ||
| 'react/no-did-update-set-state': 2, | ||
| 'react/no-find-dom-node': 2, | ||
| 'react/no-multi-comp': [ | ||
| 2, | ||
| { | ||
| ignoreStateless: true | ||
| } | ||
| ], | ||
| 'react/no-render-return-value': 2, | ||
| 'react/no-string-refs': 2, | ||
| 'react/no-unused-prop-types': 2, | ||
| 'react/prefer-es6-class': 2, | ||
| radix: 0 | ||
| } | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| *.pbxproj -text | ||
| # specific for windows script files | ||
| *.bat text eol=crlf |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of
No new line ...warningsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I will fix that!