Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detox: Update Connect Tests #1611

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Detox: Update Connect Tests #1611

merged 2 commits into from
Jun 2, 2020
+111 −153

Conversation

ibrahimtaveras00
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 commented Jun 2, 2020 •
edited
Loading

This PR started as an update for connect tests and then just turned into an update for detox tests overall.

Things covered:

  • Update browser tests and dapp-initiated-txn files to take into account new connect screen designs
  • use testID for signing transactions instead of by text
  • noticed that in a few places typing on Android emulator is extremely slow so used replaceText instead of typeText in places where a lot of characters are being used
  • removed approve screen test flow at https://metamask.github.io/test-dapp/ from dapp-initiated-txn.spec.js for a few reasons (1. This site is constantly being changed, and 2. The gas eats up a lot of ETH as it's always over $20 to create a token)
  • fixed some issues with addressbook tests on android (also found an issue while fixing = Delete is hidden when editing a contact #1610)

@ibrahimtaveras00 ibrahimtaveras00 requested a review from a team as a code owner June 2, 2020 17:55
estebanmino
estebanmino approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ibrahimtaveras00 ibrahimtaveras00 merged commit 81414fd into develop Jun 2, 2020
@ibrahimtaveras00 ibrahimtaveras00 deleted the detox/connect-screen-updates branch June 2, 2020 18:25
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@ibrahimtaveras00
make detox great again (#1611)
aeaf41c 
Co-authored-by: Ibrahim Taveras <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibrahimtaveras00 @estebanmino