Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font Euclid #1694

Merged
merged 6 commits into from
Jul 22, 2020
Merged

Update font Euclid #1694

merged 6 commits into from
Jul 22, 2020

Conversation

andrepimenta
Copy link
Member

Description

This PR implements the new font EuclidCircularB

@andrepimenta andrepimenta requested a review from a team as a code owner July 14, 2020 14:15
@ibrahimtaveras00
Copy link
Contributor

What do you all think about including this in regression testing since I'd be looking at all the views anyway?

cc: @omnat

@omnat
Copy link
Contributor

omnat commented Jul 21, 2020

Sounds good @ibrahimtaveras00

@ibrahimtaveras00 ibrahimtaveras00 added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 21, 2020
# Conflicts:
#	app/components/UI/TransactionReview/TransactionReviewData/__snapshots__/index.test.js.snap
#	app/components/UI/TransactionReview/TransactionReviewFeeCard/__snapshots__/index.test.js.snap
@andrepimenta andrepimenta merged commit da043c9 into develop Jul 22, 2020
@andrepimenta andrepimenta deleted the feature/update-fonts-euclid branch July 22, 2020 12:47
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* Update to new fonts and fix bold style on android

* Removed Circular font from project

* Update tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants