Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: accounts disappearing after password entry #1699

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Fix: accounts disappearing after password entry #1699

merged 2 commits into from
Jul 22, 2020

Conversation

EtDu
Copy link
Contributor

@EtDu EtDu commented Jul 16, 2020 •
edited
Loading

@EtDu
ChoosePassword: update preferencesControllerState after adding accoun…
2d8e255 
…ts, before passing into PreferencesController.update()
@EtDu EtDu requested a review from a team as a code owner July 16, 2020 05:29
@EtDu EtDu changed the title ChoosePassword: update preferencesControllerState after adding accoun… Fix: accounts disappearing after password entry Jul 16, 2020
@EtDu EtDu added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 16, 2020
@EtDu
Copy link
Contributor Author

EtDu commented Jul 16, 2020 •
edited
Loading

Seems ridiculous but it works. local preferencesControllerState state wasn't updating, so we were passing stale state to PreferencesController.update()

@ibrahimtaveras00 ibrahimtaveras00 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 21, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is fixed with having multiple accounts, however, this issue is not fixed with imported accounts (imported account disappears upon account account creation and the only way to get it back is to re-import it).

However, I don't see this as an issue any longer once #1692 gets merged since we are creating password before the wallet is even created thus we won't have this issue (I tested this flow on that branch and the imported account stays there). So with that being said, this is a QA passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jul 22, 2020
@EtDu EtDu merged commit 86db9f4 into develop Jul 22, 2020
@EtDu EtDu deleted the account-update-password branch July 22, 2020 03:15
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@EtDu
ChoosePassword: update preferencesControllerState after adding accoun…
b1ec08b 
…ts, before passing into PreferencesController.update() (#1699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User asked to backup seed phrase then loses accounts
3 participants
@EtDu @rickycodes @ibrahimtaveras00