Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comma causing invalid send amount #1736

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Fix comma causing invalid send amount #1736

merged 2 commits into from
Aug 11, 2020

Conversation

EtDu
Copy link
Contributor

@EtDu EtDu commented Jul 30, 2020

Description

Using a comma instead of a period in the send amount was causing it to be invalid

Issue

Resolves #1724

@EtDu EtDu requested a review from a team as a code owner July 30, 2020 03:51
@ibrahimtaveras00 ibrahimtaveras00 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 6, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 10, 2020
@EtDu EtDu merged commit 808fe63 into develop Aug 11, 2020
@EtDu EtDu deleted the comma-invalid-amount branch August 11, 2020 04:54
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@EtDu
Amount: fix comma causing invalid send amount (#1736)
4cf3f1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send amount input does not accept commas from iOS numeric keypad
4 participants
@EtDu @estebanmino @ibrahimtaveras00 @omnat