Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser newPageData state undefined #1765

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Browser newPageData state undefined #1765

merged 3 commits into from
Aug 11, 2020

Conversation

estebanmino
Copy link
Contributor

Description

newPageData is undefined in some cases so https://github.com/MetaMask/metamask-mobile/compare/browser-state-undefined?expand=1#diff-6b45a5c860cb93a60df5eb3c17e26a42R1441 was crashing
https://sentry.io/organizations/metamask/issues/1828172507/?project=2299799

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner August 10, 2020 20:23
@estebanmino estebanmino added needs-qa Any New Features that needs a full manual QA prior to being added to a release. next release labels Aug 10, 2020
andrepimenta
andrepimenta approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ibrahimtaveras00 ibrahimtaveras00 added No QA Needed Apply this label when your PR does not need any QA effort. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 11, 2020
@estebanmino estebanmino merged commit 31c5bd7 into develop Aug 11, 2020
@estebanmino estebanmino deleted the browser-state-undefined branch August 11, 2020 18:17
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Browser newPageData state undefined (#1765)
26393a2 
* init newPageData

* 511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees
No one assigned
Labels
next release No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @andrepimenta @ibrahimtaveras00