Improvement/update keychain lib #1780
Conversation
andrepimenta
added
the
needs-qa
There was a problem hiding this comment.
Issue 1:
When I come from a previous version (I tested coming from v0.2.19) that already has a password set (both with or w/o biometrics) when I attempt to log in the first time, I get the following error:
seen here = https://recordit.co/5qlqauXsuU (notice on the second attempt by just pressing log in it works)
Issue 2:
I am unable to get face recognition (android) nor iris scanner (android) to work; seen here = https://recordit.co/986vZPHcow
Basically the first time I try the scan is successful but it doesn't log me in and prompts me a second time. On the second attempt it's successful but then still doesn't log me in with this error
Device I tested = Samsung Galaxy Note 9 SM N960U
Issue 3:
Continuing from above issue, I'm still able to log in when I manually type my password. However, when I go to Settings > Security & Privacy I seen "Sign in with Fingerprint?" even though I used Iris/Face recognition and don't have fingerprint enabled on the device; seen here = https://recordit.co/kjPBjQ9ASH
Issue 4:
Even though I have iris scanner or face recognition enabled (I have fingerprint disabled on a device level) it still shows me the finger print icon rather than the intended icon. Also the text says fingerprint still.
Seen here:
ibrahimtaveras00
added
QA'd - Issues Found
|
In release mode, I was not able to reproduce issue 1, but all the other issues were still happening and couldn't see the following designs on Android with the exception of fingerprint |
…/metamask-mobile into improvement/update-keychain-lib
omnat
added
needs-qa
There was a problem hiding this comment.
New Issues I'm seeing:
-
when I came from an earlier version with PIN enabled it worked and asked for pin
but when I go to security settings I don’t see the option to toggle it off or even enable faceID/touchID -
If you have PIN enabled then log out, and log back in, PIN will be toggled off in Settings > Security and will not ask for PIN on subsequent launches unless the user re-enables it
ibrahimtaveras00
added
QA'd - Issues Found
# Conflicts: # app/components/Views/ChoosePassword/index.js # app/components/Views/ImportFromSeed/index.js # app/components/Views/ImportWallet/index.js # app/components/Views/Settings/SecuritySettings/index.js # app/components/Views/SyncWithExtension/index.js # ios/MetaMask.xcodeproj/project.pbxproj
ibrahimtaveras00
added
QA Passed
* Update keychain * Update accessible * setUserAuthenticationValidityDurationSeconds * pack * proguard * enable biometrics * settings * enterpasswordui * enterpasswordui * cleanup * fixbiometrics * wording * Fix showing biometrics option when not enabled * 535 * 1.0.5 * Refactor keychain access * Fix passcode on android * bump * Fix disable biometrics by choice on import from seed * Fix reset password with biometrics android * Fallback to password for biometric error * Dont reset state if reset password failed * Catch biometric error * Update comment * ci * unit Co-authored-by: Ibrahim Taveras <[email protected]> Co-authored-by: Esteban Miño <[email protected]>
Description
Update keychain library.
@ibrahimtaveras00 It's important to test updating the app from previous versions, and making sure the biometrics and 'remember me' still works. Also now we should support: