Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/protect wallet modal receive request #1788

Merged
merged 6 commits into from
Aug 20, 2020
Merged

bugfix/protect wallet modal receive request #1788

merged 6 commits into from
Aug 20, 2020

Conversation

estebanmino
Copy link
Contributor

Description

https://recordit.co/hRjvtiHwkc

Protect wallet modal wasn't working when closing QA code

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner August 19, 2020 21:39
@estebanmino estebanmino added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. next release labels Aug 19, 2020
ibrahimtaveras00
ibrahimtaveras00 suggested changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tapping on the QR modal works

However, tapping on copy nor share do not work

image

It only works if I kill the app and relaunch; seen here = https://recordit.co/bAIj0XGWWY

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 19, 2020
@estebanmino
Copy link
Contributor Author

@ibrahimtaveras00 fixed

@estebanmino estebanmino added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Aug 20, 2020
andrepimenta
andrepimenta approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ibrahimtaveras00
ibrahimtaveras00 approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes look good, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 20, 2020
@estebanmino estebanmino merged commit f3cfd21 into develop Aug 20, 2020
@estebanmino estebanmino deleted the bugfix/protect-wallet-modal-receive-request branch August 20, 2020 21:47
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix/protect wallet modal receive request (#1788)
6497e1f 
* fix

* 520

* changelog

* fix

* snaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @andrepimenta @ibrahimtaveras00