Detox/ Update e2e based on v1 updates #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahimtaveras00
changed the title
ibrahimtaveras00
added
the
needs-dev-review
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* fix a lot of tests * fixed browser test Co-authored-by: Ibrahim Taveras <[email protected]> Co-authored-by: Esteban Miño <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing all e2e tests to work with all our v1 updates (forcing password creation)
Deleted dapp-initiated-txn.spec.js since we no longer support editing amount on dapp txn's and it was costly to spend so much ETH on each test run. If we choose to incorporate editing amounts on dapps in the future, I can bring this one back.
Deleted metametrics-opt-out.spec.js since I already test opting out in onboarding-wizard-opt-out.spec.js it was redundant. I also added a check on settings > security & privacy to make sure metametrics is in fact disabled, and then to re-enable it.
I updated a typo in locales > en.json from loosing to losing
I also had to comment out ethereum enable test on browser-test which should work when Improvement/browser refactor #1829 is merged to develop
I also had to comment out two tests pertaining to browser homepage which should work whenever this is fixed
Both OS's passed 👍
If you want to see it in action run the following:
Android -
detox build -c android.emu.debug && detox test -c android.emu.debug
iOS -
detox build -c ios.sim.debug && detox test -c ios.sim.debug