Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/small UI fixes #2042

Merged
merged 11 commits into from
Dec 11, 2020
Merged

Bugfix/small UI fixes #2042

merged 11 commits into from
Dec 11, 2020

Conversation

rickycodes
Copy link
Contributor

@rickycodes rickycodes commented Dec 3, 2020 •
edited
Loading

Description

Just a couple small UI fixes. I noticed the spacing of the warning indication when you haven't backed up is a bit off:

before:

image

after:

image

One other thing I noticed is that we're displaying the back button on our congratulations screen, which I think is an unnecessary action for that page...

before:

image

after:

image

@rickycodes rickycodes requested a review from a team as a code owner December 3, 2020 20:20
@rickycodes rickycodes added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 3, 2020
@omnat omnat added the design-review Any feature that needs feedback from the design team label Dec 3, 2020
@rickycodes rickycodes changed the title Bugfix/small ui fixes Bugfix/small UI fixes Dec 4, 2020
@cjeria
Copy link

cjeria commented Dec 7, 2020

These fixes look good. The only inconsistency I notice here is the "Congratulations" font. It looks like Roboto, not Euclid.

@rickycodes
Copy link
Contributor Author

rickycodes commented Dec 8, 2020 •
edited
Loading

The only inconsistency I notice here is the "Congratulations" font. It looks like Roboto, not Euclid.

I noticed we have an extraBold style that doesn't work on Android. I removed that and used our bold style which seems to look fine? I've updated the after screenshot above.

@rickycodes rickycodes removed the design-review Any feature that needs feedback from the design team label Dec 8, 2020
@omnat omnat added needs-design Feature that requires UI/UX design design-review Any feature that needs feedback from the design team labels Dec 9, 2020
@rickycodes rickycodes removed design-review Any feature that needs feedback from the design team needs-design Feature that requires UI/UX design labels Dec 9, 2020
estebanmino
estebanmino approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estebanmino estebanmino removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 10, 2020
@rickycodes rickycodes force-pushed the bugfix/small-ui-fixes branch from 84bb28a to 48ff546 Compare December 10, 2020 18:45
@rickycodes
Copy link
Contributor Author

couple small changes based on design QA:

On the drawer it should only say "Unprotected" as to reduce the likelihood of the string breaking on smaller devices:

image

Secondly we're moving the "Security & Privacy" settings section below "General":

image

@cjeria
Copy link

cjeria commented Dec 10, 2020

LGTM @rickycodes

@rickycodes rickycodes force-pushed the bugfix/small-ui-fixes branch 2 times, most recently from e2ba7f6 to 94b1ec9 Compare December 11, 2020 00:00
ibrahimtaveras00
ibrahimtaveras00 suggested changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that although we removed the back button on the top left, on android, I still can push the device back button and get redirected; seen here = http://recordit.co/mLaye65Qd0

do we also want to remove that option as well?

same thing goes for the import seed phrase flow, and sync with extension flow = http://recordit.co/RdK9B8EfWW

@ibrahimtaveras00 ibrahimtaveras00 added QA'd but questions A QA run through has been done but you need clarification on minor issues you found and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Dec 11, 2020
@rickycodes
Copy link
Contributor Author

rickycodes commented Dec 11, 2020 •
edited
Loading

@ibrahimtaveras00 the hardware back button should be disabled now as well :)

@rickycodes rickycodes force-pushed the bugfix/small-ui-fixes branch from efb8e1d to b76e4c4 Compare December 11, 2020 17:31
ibrahimtaveras00
ibrahimtaveras00 approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@rickycodes rickycodes merged commit d2ee9a8 into develop Dec 11, 2020
@rickycodes rickycodes deleted the bugfix/small-ui-fixes branch December 11, 2020 21:55
@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA'd but questions A QA run through has been done but you need clarification on minor issues you found labels Dec 11, 2020
@rickycodes rickycodes mentioned this pull request Dec 15, 2020
Merged
2 tasks
@omnat
Copy link
Contributor

omnat commented Jan 21, 2021

Didn't realized we made some changes on this screen. Pointed to @cjeria just yesterday that we need copy update on this success screen. Too late for this release, but captured in #2136 to address later.

rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Bugfix/small UI fixes (#2042)
12cca4a 
* add spacing on warning

* hide back button on congratulations screen

* update unit tests

* Remove extraBold

* Update tests

* Use only one word on Drawer (Unprotected)

* Move settings up

* Update snapshots

* Disable hardwareBackPress on Congratulations screen

* Add HARDWARE_BACK_PRESS const

* Disable hardwareBackPress on sync too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickycodes @cjeria @omnat @estebanmino @ibrahimtaveras00