Split AssetsController into TokensController and CollectiblesController #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachunei
reviewed
Jul 9, 2021
app/components/Views/Wallet/index.js
Outdated
Comment on lines
190
to
194
| }, | ||
| ...tokens | ||
| } | ||
| ]; | ||
| if (tokens && Array.isArray(tokens)) { | ||
| assets = [...assets, ...tokens]; | ||
| } |
There was a problem hiding this comment.
Is there a case where tokens can be other than array, null, undefined?
If not this would not be necessary and we can just change ...tokens to ...(tokens || [])
There was a problem hiding this comment.
Yeah this wasn't meant to be included but your suggestion is safer than how it is now
adonesky1
force-pushed
the
split-assets-controller
branch
2 times, most recently
from
20bb5ba to
4698667
Compare
adonesky1
force-pushed
the
split-assets-controller
branch
2 times, most recently
from
45bbf86 to
1113350
Compare
wachunei
added
the
needs-qa
adonesky1
force-pushed
the
split-assets-controller
branch
from
acc05c0 to
44f0fc9
Compare
adonesky1
force-pushed
the
split-assets-controller
branch
from
44f0fc9 to
eb9ba92
Compare
adonesky1
changed the title
adonesky1
force-pushed
the
split-assets-controller
branch
from
eb9ba92 to
15c8055
Compare
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
…er (#2881) * Split AssetsController into TokensController and CollectiblesController * add back split in AssetDetectionController instantiation * add config to tokensController Co-authored-by: Ibrahim Taveras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required changes to land the split AssetsController work (currently in PR) in the controllers repo.
Issue
MetaMask/core#516