Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add browser analytics #3104

Merged
merged 12 commits into from
Sep 8, 2021
Merged

[FEATURE] Add browser analytics #3104

merged 12 commits into from
Sep 8, 2021

Conversation

gantunesr
Copy link
Member

Description

Track the following browser events.

  • Browser opened
  • Select search option
  • Open new tab
  • Switch network
  • Use browser navigation (Home, Forward, Back)
  • Share website
  • Reload website
  • Add website to favorites

@gantunesr gantunesr added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 8, 2021
@gantunesr gantunesr requested a review from a team September 8, 2021 02:47
@gantunesr gantunesr self-assigned this Sep 8, 2021
sethkfman
sethkfman reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments

app/util/analyticsV2.js Outdated Show resolved Hide resolved
app/components/UI/BrowserBottomBar/index.js Show resolved Hide resolved
sethkfman
sethkfman approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit a19b31c into develop Sep 8, 2021
@gantunesr gantunesr deleted the feat/browser-analytics branch September 8, 2021 16:53
@Cal-L Cal-L removed No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 8, 2021
@gantunesr gantunesr mentioned this pull request Sep 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees

@gantunesr gantunesr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gantunesr @sethkfman @Cal-L