Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics - Track "Account Switcher" events #3319

Merged
merged 7 commits into from
Oct 21, 2021
Merged

Analytics - Track "Account Switcher" events #3319

merged 7 commits into from
Oct 21, 2021

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Oct 21, 2021 •
edited
Loading

Add events to track the following actions:

  • Opened Account Switcher: Account AccountRightButton is pressed.
  • Switched Account: Account is select in AcountList

@gantunesr gantunesr requested a review from a team October 21, 2021 04:59
@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. labels Oct 21, 2021
@gantunesr gantunesr changed the title Analytics - Track "Opened Account Switcher" Analytics - Track "Account Switcher" events Oct 21, 2021
@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 21, 2021
wachunei
wachunei approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit f3b6258 into develop Oct 21, 2021
@gantunesr gantunesr deleted the feat/switch-account-event branch October 21, 2021 19:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2021
@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wachunei wachunei wachunei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gantunesr @wachunei @Cal-L