Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3.0][FIX] Prevent crash when funds warning is pressed #4178

Merged
merged 19 commits into from
May 26, 2022
+48 −57
Merged

[5.3.0][FIX] Prevent crash when funds warning is pressed #4178

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1fc843e
fixed
tommasini Apr 28, 2022
df44bb4
Update snapshots
Apr 28, 2022
711846b
added binance chain and polygon to the warning
tommasini Apr 29, 2022
ed54483
added new translations
tommasini Apr 29, 2022
671ec56
added fantom avax and celo, also changed the behaviour on another tra…
tommasini Apr 29, 2022
16f5a9f
hexadecimal chain ids fixed
tommasini Apr 29, 2022
39994ee
update of Send flow navigation with browser view and faucet navigatio…
tommasini May 2, 2022
7d4e1ba
fix go to faucet in sendFlow confirm screen
tommasini May 2, 2022
dea2250
Merge branch 'main' into fix/4177-fix-crash-on-press-transaction-warning
tommasini May 10, 2022
6c48b1b
Merge branch 'main' into fix/4177-fix-crash-on-press-transaction-warning
tommasini May 11, 2022
54893f6
dev reviews update
tommasini May 11, 2022
b52bcac
Merge branch main into fix/4177-fix-crash-on-press-transaction-warning
tommasini May 11, 2022
b322db3
fix bug unknown networks on network list
tommasini May 12, 2022
9b30370
Merge branch 'main' into fix/4177-fix-crash-on-press-transaction-warning
tommasini May 12, 2022
997ab3b
browser view not accessible on the stack navigator of confirmScreen
tommasini May 12, 2022
7b1e752
fix
tommasini May 12, 2022
c698ebe
Merge branch 'main' into fix/4177-fix-crash-on-press-transaction-warning
tommasini May 24, 2022
0d044b2
request changes and use new constants
tommasini May 26, 2022
0a4052c
Merge branch 'main' into fix/4177-fix-crash-on-press-transaction-warning
Fatxx May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/UI/TransactionReview/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`TransactionReview should render correctly 1`] = `
<QRHardwareAwareness
<withNavigation(QRHardwareAwareness)
accounts={Array []}
browser={
Object {
Expand Down
3 changes: 2 additions & 1 deletion app/components/UI/TransactionReview/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import { getTokenList } from '../../../reducers/tokens';
import { ThemeContext, mockTheme } from '../../../util/theme';
import withQRHardwareAwareness from '../QRHardware/withQRHardwareAwareness';
import QRSigningDetails from '../QRHardware/QRSigningDetails';
import { withNavigation } from '@react-navigation/compat';

const createStyles = (colors) =>
StyleSheet.create({
Expand Down Expand Up @@ -467,4 +468,4 @@ const mapStateToProps = (state) => ({

TransactionReview.contextType = ThemeContext;

export default connect(mapStateToProps)(withQRHardwareAwareness(TransactionReview));
export default connect(mapStateToProps)(withNavigation(withQRHardwareAwareness(TransactionReview)));