Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Add rounded corners to svg NFTs #4247

Merged
merged 8 commits into from
Jun 14, 2022
Merged

[IMPROVEMENT] Add rounded corners to svg NFTs #4247

merged 8 commits into from
Jun 14, 2022

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented May 6, 2022 •
edited
Loading

Description
The problem it was the SVG NFTs were not with round corners

Proposed Solution
When it was SVG add the style overflow:'hidden' to the svg container view.

Code Impact
Very low

Test Cases
Case1:

  • import one NFT what is SVG file type
  • Must be round corner

Screenshots/Recordings
image

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses #4203

@tommasini tommasini requested a review from a team as a code owner May 6, 2022 17:00
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gantunesr gantunesr changed the title When NFT is a SVG it have round corners [IMPROVEMENT] Add rounded corners to svg NFTs May 10, 2022
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 17, 2022
Fatxx
Fatxx approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fatxx Fatxx added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 2, 2022
@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed Mobile QA board needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 14, 2022
@tommasini tommasini merged commit 5ab917c into main Jun 14, 2022
@tommasini tommasini deleted the fix/4203-update-nft-thumbnails branch June 14, 2022 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2022
@tommasini tommasini added the release-5.3.0 Issue or pull request that will be included in release 5.3.0 label Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
release-5.3.0 Issue or pull request that will be included in release 5.3.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommasini @Fatxx @gantunesr