Error handling when no crypto currencies available on selected region #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
alaahd
changed the title
rickycodes
reviewed
May 17, 2022
rickycodes
reviewed
May 17, 2022
|
I have pushed on more commit for improvement suggested by @wachunei appreciate if we can review again. |
wachunei
requested changes
May 18, 2022
app/components/UI/FiatOnRampAggregator/components/ErrorView.tsx
Outdated
Show resolved
Hide resolved
wachunei
approved these changes
May 18, 2022
wachunei
approved these changes
May 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will notify the user once cryptocurrencies are not available to purchase on specific selected region on the selected network.
For example: User selected region is "Alabama - USA" and the wallet is connected to "Optimism" network.
We still give the user an option to choose a different region.
Checklist
Screenshots/Recordings
If applicable, add screenshots or recordings to visualize the changes
Issue
Progresses #???