Add On-Ramp Aggregator Analytics #4362
Conversation
|
ah, forgot to run snapshots updates |
| const amountIsBelowMinimum = useMemo( | ||
| () => amountNumber !== 0 && limits && amountNumber < limits.minAmount, | ||
| [amountNumber, limits], | ||
| ); |
There was a problem hiding this comment.
I think using useMemo for basic methods can harm the performance. I'll leave this article here as reference
| amount: number; | ||
| location: ScreenLocation; | ||
| }; | ||
| ONRAMP_CANCELED: { |
There was a problem hiding this comment.
I just noticed we have this inconsistency between "Canceled" and "Cancelled"
| ONRAMP_CANCELED: { | |
| ONRAMP_CANCELLED: { |
There was a problem hiding this comment.
Great catch. I will update.
There was a problem hiding this comment.
I just checked, this is not a mistake.
There was a problem hiding this comment.
I see, regardless we should agree on using only one word (nitpick). In this same PR you can see that CANCELLED and CANCELED are being used, this occurs in other parts of the app too.
There was a problem hiding this comment.
Good catch. Let's go with Canceled—this is what John Brennan recommends in the new MetaMetrics Improvement Proposal.
No description provided.