-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.5] Keystone: fix 2 bugs #4430
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @soralit! I'm leaving some questions for the moment
462170e
to
c682413
Compare
Hi @gantunesr , PR was updated. I found the restoring process was duplicated in two place so I combined them into one, what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soralit I am unable to log in after a password change. Basically, when I attempt to change my password with biometrics log-in disabled I get an error “invalid password”.
To reproduce:
import your wallet
go to the privacy and security page
tap on the “change password” button
enter your current password to proceed
now you should be taken to the create password screen
enter a new password
before creating the new password toggle off “log in with biometrics”
proceed and create that new password
After the password change was successful
kill the app
relaunch the app
login with your new password. Notice the error
I reproduced without binding my keystone device: http://recordit.co/jt2b4IjCxm
And after I bind my keystone device: http://recordit.co/iKkwuYgxpP
Hey @soralit any update on this at all? :) |
c682413
to
c18b619
Compare
Hi @AlexJupiter @cortisiko , really sorry for the late reply. I just fixed this issue. Thanks for your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is 🌮 🌮
Description
This PR fixed 2 bugs with Keystone:
Checklist
Screenshots/Recordings
If applicable, add screenshots or recordings to visualize the changes
Issue
Progresses https://github.com/MetaMask/qr-hardware-wallets/issues/7
Progresses https://github.com/MetaMask/qr-hardware-wallets/issues/6