Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add On-Ramp generic error view event #4742

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Add On-Ramp generic error view event #4742

merged 3 commits into from
Aug 9, 2022

Conversation

wachunei
Copy link
Member

Description

This PR tracks the 'On-ramp Error' event when the Error View is displayed.

The error payload is:

  ONRAMP_ERROR: {
    location: ScreenLocation;
    message: string;
    payment_method_id?: string;
    region?: string;
    currency_source?: string;
    currency_destination?: string;
  };

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features release-5.6.0 Issue or pull request that will be included in release 5.6.0 labels Jul 27, 2022
@wachunei wachunei requested a review from a team as a code owner July 27, 2022 22:59
Cal-L
Cal-L approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a question. LGTM!

app/components/UI/FiatOnRampAggregator/components/ErrorView.tsx Show resolved Hide resolved
@alaahd
Copy link
Contributor

alaahd commented Aug 3, 2022

LGTM!

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 3, 2022
@wachunei wachunei removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 9, 2022
@wachunei wachunei merged commit 7c641ef into main Aug 9, 2022
@wachunei wachunei deleted the feature/onramp-error-event branch August 9, 2022 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-5.6.0 Issue or pull request that will be included in release 5.6.0 team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachunei @alaahd @Cal-L