[FIX] Block explorer crash #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantunesr
added
the
needs-dev-review
…k/metamask-mobile into fix/block-explorer-crash
Cal-L
removed
the
needs-dev-review
gantunesr
added
needs-qa
cortisiko
added
QA in Progress
cortisiko
requested changes
Aug 4, 2022
There was a problem hiding this comment.
@gantunesr The initial Fix looks good. I did however run into an issue where I attempted to edit the network and then add the block explorer URL. Upon doing so, I do not see the option to get to the block explorer within the app/view token details.
See recording
compared to v5.3: https://polygonscan.com/
cortisiko
added
QA'd - Issues Found
cortisiko
added
QA in Progress
cortisiko
added
QA Passed
cortisiko
added
the
release-5.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
There's a crash while trying to access an undefined block explorer, to reproduce the issue just add manually a new network without the block explorer url and try to access it.
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
BUG
https://user-images.githubusercontent.com/17601467/182456429-ea8f9d8a-fac8-4bc0-818a-d5e5ce3af49f.mov
FIX
https://user-images.githubusercontent.com/17601467/182456263-fc2b36c9-9716-4bf3-89d0-4ba05cafdb83.mov
Issue
Progresses #4753
Checklist