Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component/4779 audit #4809

Merged
merged 21 commits into from
Aug 9, 2022
Merged

Component/4779 audit #4809

merged 21 commits into from
Aug 9, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Aug 5, 2022

Description

#4779

This PR is meant to both clean up and wrap up the components created for Permission system so far. Epic is tracked here #4072. Updates include adding missing comments, updating README with Usage section, setting default values for props, and more.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L marked this pull request as ready for review August 5, 2022 21:44
@Cal-L Cal-L requested a review from a team as a code owner August 5, 2022 21:44
@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.6.0 Issue or pull request that will be included in release 5.6.0 labels Aug 5, 2022
Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. Nothing major

@Cal-L Cal-L removed the release-5.6.0 Issue or pull request that will be included in release 5.6.0 label Aug 9, 2022
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit 983f494 into main Aug 9, 2022
@Cal-L Cal-L deleted the component/4779-audit branch August 9, 2022 21:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2022
@Cal-L Cal-L added release-5.7.0 Issue or pull request that will be included in release 5.7.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.7.0 Issue or pull request that will be included in release 5.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants