-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component/4779 audit #4809
Component/4779 audit #4809
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. Nothing major
app/component-library/components/Avatars/AvatarBase/AvatarBase.types.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/Avatars/AvatarFavicon/AvatarFavicon.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/Avatars/AvatarFavicon/AvatarFavicon.types.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/Avatars/AvatarFavicon/AvatarFavicon.types.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/Avatars/AvatarFavicon/AvatarFavicon.types.ts
Show resolved
Hide resolved
app/component-library/components/Cells/CellAccount/CellAccount.types.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/Avatars/AvatarToken/AvatarToken.types.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/Avatars/AvatarToken/AvatarToken.types.ts
Outdated
Show resolved
Hide resolved
* Support local images * Refine stories
…tamask-mobile into component/4779-audit
…to component/4779-audit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
#4779
This PR is meant to both clean up and wrap up the components created for Permission system so far. Epic is tracked here #4072. Updates include adding missing comments, updating README with Usage section, setting default values for props, and more.
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist