Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InApp Browser package #5010

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Add InApp Browser package #5010

merged 1 commit into from
Sep 28, 2022

Conversation

wachunei
Copy link
Member

Description

This PR adds InApp Browser package, a wrapper around Chrome Custom Tabs and native Safari.
Related discussion is here: https://consensys.slack.com/archives/CBW7S9FSN/p1660269263397649

TODO:

  • determine release version

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features labels Sep 20, 2022
@wachunei wachunei requested a review from a team as a code owner September 20, 2022 13:38
@socket-security
Copy link

socket-security bot commented Sep 20, 2022 •
edited
Loading

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
[email protected] (added) postinstall package.json
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

andreahaku
andreahaku approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.9.0 Issue or pull request that will be included in release 5.9.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 28, 2022
@sethkfman sethkfman merged commit a4ebbe5 into main Sep 28, 2022
@sethkfman sethkfman deleted the feature/onramp-inapp-browser branch September 28, 2022 17:39
@sethkfman
Copy link
Contributor

Branch was merged. LavaMoat post install script handles the Socket issue brought up during CI.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees
No one assigned
Labels
release-5.9.0 Issue or pull request that will be included in release 5.9.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachunei @sethkfman @andreahaku