Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component/4722-accordion #5041

Merged
merged 8 commits into from
Oct 7, 2022
Merged

Component/4722-accordion #5041

merged 8 commits into from
Oct 7, 2022

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Add accordion component to Design System

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 27, 2022
@brianacnguyen brianacnguyen self-assigned this Sep 27, 2022
@brianacnguyen brianacnguyen requested a review from a team as a code owner September 27, 2022 20:59
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolving comments

@brianacnguyen brianacnguyen merged commit a612b06 into main Oct 7, 2022
@brianacnguyen brianacnguyen deleted the component/4722-accordion branch October 7, 2022 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants