Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ANALYTICS] Events migration #5139

Merged
merged 91 commits into from
Feb 28, 2023
Merged

[ANALYTICS] Events migration #5139

merged 91 commits into from
Feb 28, 2023

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Oct 22, 2022 •
edited
Loading

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?

As part of the Segment integration, it's necessary to migrate all events from MixPanel to Segment.

2. What is the improvement/solution?

Events migration to Segment.

Screenshots/Recordings

Not applicable.

Issue

Progresses #https://github.com/MetaMask/mobile-planning/issues/372

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

gantunesr added 24 commits October 9, 2022 13:07
@gantunesr
Update events
f5183d9
@gantunesr
Migrate AnalyticsV2 events
d09e98a
@gantunesr
Fix linting issues
805b7cb
@gantunesr
Fix broken events
de08720
@gantunesr
Update utils trackEventV2 method
4cc4c96
@gantunesr
Update events
80a2a7c
@gantunesr
Migrate legacy events
510f89e
@gantunesr
Lint
a5f2b45
@gantunesr
Delete old events file
6965c70
@gantunesr
Refactor analytics utils file to TS
c14d4ba
@gantunesr
Migrate legacy events
4bf3f90
@gantunesr
Update MetaMetrics class to include methods for Id and state
eb0d3e8
@gantunesr
Fix broken events after migration
38183ca
@gantunesr
Migrate user properties
e24f4b1
@gantunesr
Update identify method
a2b1695
@gantunesr
Fix imports
92cd6f3
@gantunesr
Add UserIdentityProperties interface
ac5c096
@gantunesr
Add identify constants
9e729ea
@gantunesr
Fix bug for missing ONBOARDING_WIZARD_STEP_DESCRIPTION
7c77a58
@gantunesr
Improve typing
95438e0
@gantunesr
Update dependencies
3a10af6
@gantunesr
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
1071e98 
…to analytics/migrate-events
@gantunesr
Fix opt in and out feature
2361419
@gantunesr
Remove opt out alert
38eb16e
@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 22, 2022
@gantunesr gantunesr changed the title [Analytics] Events migration [ANALYTICS] Events migration Oct 22, 2022
@gantunesr gantunesr marked this pull request as ready for review October 22, 2022 23:15
@gantunesr gantunesr requested a review from a team as a code owner October 22, 2022 23:15
@owencraston owencraston added the release-5.11.0 Issue or pull request that will be included in release 5.11.0 label Oct 25, 2022
@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board labels Feb 28, 2023
@gantunesr gantunesr mentioned this pull request Feb 28, 2023
Merged
3 tasks
NicolasMassart
NicolasMassart approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great work.
Also thank for the time you spent pair reviewing this and explaining to me.

@gantunesr gantunesr removed the request for review from tommasini February 28, 2023 20:36
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 28, 2023
@gantunesr gantunesr merged commit e3d8124 into main Feb 28, 2023
@gantunesr gantunesr deleted the analytics/migrate-events branch February 28, 2023 23:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2023
@gantunesr gantunesr added release-6.2.0 Issue or pull request that will be included in release 6.2.0 team-mobile-client labels Mar 1, 2023
tommasini
tommasini reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Wrong PR

@gauthierpetetin gauthierpetetin added the team-mobile-platform Mobile Platform team label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wachunei wachunei wachunei left review comments

@tommasini tommasini tommasini left review comments

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@owencraston owencraston owencraston approved these changes

Assignees
No one assigned
Labels
release-6.2.0 Issue or pull request that will be included in release 6.2.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform Mobile Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gantunesr @wachunei @NicolasMassart @owencraston @tommasini @gauthierpetetin @cortisiko