Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onramp: Add exclude from purchases to onramp aggregator orders #5195

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Onramp: Add exclude from purchases to onramp aggregator orders #5195

merged 1 commit into from
Nov 3, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Nov 3, 2022

Description

This PR adds a missing excludeFromPurchases field to orders.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.10.0 Issue or pull request that will be included in release 5.10.0 labels Nov 3, 2022
@wachunei wachunei marked this pull request as ready for review November 3, 2022 15:25
@wachunei wachunei requested a review from a team as a code owner November 3, 2022 15:25
gantunesr
gantunesr approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 3, 2022
@wachunei wachunei merged commit 24858a3 into main Nov 3, 2022
@wachunei wachunei deleted the fix/onramp-exclude-from-purchases branch November 3, 2022 16:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
release-5.10.0 Issue or pull request that will be included in release 5.10.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wachunei @gantunesr