Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-Ramp: Settings and Activation Keys #5455

Merged
merged 9 commits into from
Jan 10, 2023
Merged

On-Ramp: Settings and Activation Keys #5455

merged 9 commits into from
Jan 10, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jan 5, 2023 •
edited
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR upgrades on-ramp-sdk to version 1.6.0, this version includes support for SDK Activation Keys. Changes include state management for Activation Keys through a new Settings Panel.

Activation Keys are used internally and with our providers to enable their integration and perform QA testing with a single build that can be distributed, allowing them to set their corresponding key.

Screenshots/Recordings
Settings screen:
Simulator Screen Shot - iPhone 14 Pro - 2023-01-05 at 14 57 14 Simulator Screen Shot - iPhone 14 Pro - 2023-01-05 at 17 07 24

Acceptance criteria

Production build:

  • Settings show up and user can reset their region

Local/UAT Build:

  • Same as above + activation keys can be added, removed and deactivated, and correctly taking effect.

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows release-5.14.0 Issue or pull request that will be included in release 5.14.0 labels Jan 5, 2023
@wachunei wachunei marked this pull request as ready for review January 6, 2023 13:49
@wachunei wachunei requested a review from a team as a code owner January 6, 2023 13:49
@wachunei wachunei requested a review from blackdevelopa January 9, 2023 22:57
blackdevelopa
blackdevelopa approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wachunei. Looks good to me

@wachunei wachunei merged commit 6144d35 into main Jan 10, 2023
@wachunei wachunei deleted the feature/onramp-settings branch January 10, 2023 13:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
@wachunei wachunei added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-ramp-qa Tickets that need feature QA on the ramps flows labels Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
release-5.14.0 Issue or pull request that will be included in release 5.14.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wachunei @blackdevelopa