Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] RN Patch Version #5683

Merged
merged 2 commits into from
Feb 15, 2023
Merged

[FIX] RN Patch Version #5683

merged 2 commits into from
Feb 15, 2023

Conversation

sethkfman
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
1. What is the reason for the change?

  • The current RN match in main does not point to the version that is actually in the package.json which causes a warning to be thrown.
    2. What is the improvement/solution?
  • Updated the patch version
    Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • [NA] There is a related GitHub issue
  • [NA] Tests are included if applicable
  • [NA] Any added code is fully documented

@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client release-6.1.0 Issue or pull request that will be included in release 6.1.0 labels Feb 3, 2023
@sethkfman sethkfman requested a review from a team as a code owner February 3, 2023 22:58
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L changed the title [FIX] RN Patch Version [FIX] RN Reanimated Patch Version Feb 14, 2023
Cal-L
Cal-L approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman changed the title [FIX] RN Reanimated Patch Version [FIX] RN Patch Version Feb 14, 2023
@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 15, 2023
@sethkfman sethkfman merged commit 03bb39d into main Feb 15, 2023
@sethkfman sethkfman deleted the fix/patch-version-rn branch February 15, 2023 20:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-platform Mobile Platform team label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-6.1.0 Issue or pull request that will be included in release 6.1.0 team-mobile-platform Mobile Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethkfman @Cal-L @gauthierpetetin