fix: issue with 'dappIconUrl' in 'AccountConnect.ts'

[omridan159]

Description

This PR addresses a bug in the AccountConnect.tsx file where an unhandled exception occurs if there are no accounts connected to a dApp.
The issue arises on line 105 due to attempting to access the icon property of originatorInfo on an undefined sdkConnection.

The proposed fix safely accesses originatorInfo by adding an optional chaining operator before originatorInfo, ensuring that the code gracefully handles scenarios where sdkConnection might be undefined.

Screen.Recording.2024-03-08.at.14.06.10.mov

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 43.23%. Comparing base (9103133) to head (4ef0ecf).

Files	Patch %	Lines
...components/Views/AccountConnect/AccountConnect.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8887   +/-   ##
=======================================
  Coverage   43.23%   43.23%           
=======================================
  Files        1271     1271           
  Lines       30905    30905           
  Branches     3088     3088           
=======================================
  Hits        13361    13361           
  Misses      16769    16769           
  Partials      775      775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dawnseeker8]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud