Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored _onMessageFromForwarder #42

Closed
wants to merge 1 commit into from
Closed

Refactored _onMessageFromForwarder #42

wants to merge 1 commit into from

Conversation

BboyAkers
Copy link
Contributor

@BboyAkers BboyAkers commented Jul 11, 2020 •
edited
Loading

Refactored _onMessageFromForwarder to use switch statements instead of if-else. Makes it more readable and easier to follow. Let me know your thoughts 🙂 .

@BboyAkers
Refactored _onMessageFromForwarder
3b47189 
Refactored _onMessageFromForwarder to use switch statements instead of if-else. Makes it more readable and easier to follow.
@BboyAkers BboyAkers requested a review from a team as a code owner July 11, 2020 02:29
whymarrh
whymarrh suggested changes Jul 12, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely an improvement! I've left a comment about the type of the event param, and we'll need to run yarn lint --fix to resolve the lint errors, but outside of that this looks great!

@BboyAkers
Copy link
Contributor Author

Moved to pull request #44

@BboyAkers BboyAkers closed this Jul 12, 2020
@BboyAkers BboyAkers mentioned this pull request Jul 13, 2020
Merged
@whymarrh whymarrh mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BboyAkers @whymarrh