Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.0.4 #157

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

legobeat
Copy link
Contributor

No description provided.

@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 21, 2024
@legobeat legobeat marked this pull request as ready for review May 21, 2024 05:05
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@isaacs/[email protected] None +4 33.4 kB isaacs
npm/@lavamoat/[email protected] None 0 19.8 kB boneskull
npm/@lavamoat/[email protected] environment 0 45.8 kB boneskull
npm/@npmcli/[email protected] environment, network 0 17.7 kB npm-cli-ops
npm/@npmcli/[email protected] filesystem 0 26.5 kB lukekarrys
npm/@npmcli/[email protected] filesystem 0 21.8 kB npm-cli-ops
npm/@npmcli/[email protected] filesystem 0 37.5 kB npm-cli-ops
npm/@npmcli/[email protected] environment, shell 0 12.2 kB npm-cli-ops
npm/@npmcli/[email protected] environment 0 18.4 kB npm-cli-ops
npm/@pkgjs/[email protected] None 0 74.2 kB oss-bot
npm/[email protected] None 0 4.83 kB lukekarrys
npm/[email protected] network 0 31.2 kB tootallnate
npm/[email protected] network 0 38.8 kB fengmk2
npm/[email protected] None 0 5.67 kB qix
npm/[email protected] filesystem 0 20.6 kB npm-cli-ops
npm/[email protected] filesystem 0 63.5 kB npm-cli-ops
npm/[email protected] None 0 13.6 kB komagata
npm/[email protected] None 0 97.9 kB google-wombot
npm/[email protected] shell 0 60.4 kB isaacs
npm/[email protected] filesystem 0 14.4 kB npm-cli-ops
npm/[email protected] Transitive: environment +1 895 kB isaacs
npm/[email protected] None +1 707 kB npm-cli-ops
npm/[email protected] network 0 23.3 kB tootallnate
npm/[email protected] network 0 35.3 kB tootallnate
npm/[email protected] environment 0 285 kB isaacs
npm/[email protected] network 0 52.8 kB npm-cli-ops
npm/[email protected] None 0 4.96 kB isaacs
npm/[email protected] environment, network 0 46.8 kB npm-cli-ops
npm/[email protected] None 0 285 kB isaacs
npm/[email protected] environment, shell +1 1.73 MB lukekarrys
npm/[email protected] None 0 26.2 kB npm-cli-ops
npm/[email protected] None 0 28.2 kB npm-cli-ops
npm/[email protected] None 0 6.21 kB npm-cli-ops
npm/[email protected] None 0 19.1 kB npm-cli-ops
npm/[email protected] None 0 16.3 kB npm-cli-ops
npm/[email protected] filesystem 0 535 kB isaacs
npm/[email protected] None 0 12.3 kB npm-cli-ops
npm/[email protected] network 0 25.1 kB tootallnate
npm/[email protected] None 0 38.7 kB npm-cli-ops
npm/[email protected] None +1 10.1 kB sindresorhus
npm/[email protected] None 0 3.41 kB lukekarrys
npm/[email protected] None 0 2.58 kB lukekarrys
npm/[email protected] unsafe 0 7.77 kB npm-cli-ops
npm/[email protected] environment Transitive: filesystem +1 50.5 kB npm-cli-ops
npm/[email protected] None +1 29.3 kB sindresorhus

🚮 Removed packages: npm/@lavamoat/[email protected], npm/@lavamoat/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Shell access npm/[email protected]
Shell access npm/[email protected]
New author npm/[email protected]
Network access npm/[email protected]
Network access npm/[email protected]
Network access npm/[email protected]
Network access npm/[email protected]
Network access npm/@npmcli/[email protected]
Network access npm/@npmcli/[email protected]
Network access npm/@npmcli/[email protected]
Network access npm/@npmcli/[email protected]
Network access npm/@npmcli/[email protected]
New author npm/[email protected]

View full report↗︎

Next steps

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat requested review from a team, witmicko and NicholasEllul May 23, 2024 19:37
Copy link
Contributor

@NicholasEllul NicholasEllul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Reading the CHANGELOG, I see that the breaking change was minimum supported node version which wont be an issue here ✅

I did not review the socket.dev alerts so please take a moment to review or acknowledge them to satisfy the CI check. Once that is configured, please re-request a review and I will follow up with another review.

@legobeat legobeat requested a review from NicholasEllul May 31, 2024 20:25
@NicholasEllul
Copy link
Contributor

@SocketSecurity ignore-all

@legobeat legobeat merged commit 3cf9b0c into MetaMask:main Jun 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants