Fix build script #27
Merged
Fix build script #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build script has been failing since `@metamask/post-message-stream` was updated. This appears to be caused by the addition of modules to that library that were meant to be used in the context of a Web Worker. They referenced an import that only exists in a Web Worker context (`worker_threads`). They were included in the main entrypoint for the package, so browserify tried to walk the dependency graph and blew up on that line. The import has been updated to reference just the `WindowPostMessageStream` module that is used, rather than the main package entrypoint.
Merged
Gudahtt
added a commit
that referenced
this pull request
Aug 2, 2022
This reverts commit e9eddaf. This change was made to resolve a breakage introduced in `@metamask.post-message-stream`. This breakage was fixed in v6 of that library, so we don't need to use a direct import anymore. For further details, see: MetaMask/post-message-stream#49
Gudahtt
added a commit
that referenced
this pull request
Aug 3, 2022
This reverts commit e9eddaf. This change was made to resolve a breakage introduced in `@metamask.post-message-stream`. This breakage was fixed in v6 of that library, so we don't need to use a direct import anymore. For further details, see: MetaMask/post-message-stream#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build script has been failing since
@metamask/post-message-streamwas updated. This appears to be caused by the addition of modules to that library that were meant to be used in the context of a Web Worker. They referenced an import that only exists in a Web Worker context (worker_threads). They were included in the main entrypoint for the package, so browserify tried to walk the dependency graph and blew up on that line.The import has been updated to reference just the
WindowPostMessageStreammodule that is used, rather than the main package entrypoint.