Dynamically lookup the source of a block #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
Gudahtt
force-pushed
the
dynamic-lookup-of-block-source
branch
3 times, most recently
from
88f88c1 to
0f7fb93
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
dynamic-lookup-of-block-source
branch
from
0f7fb93 to
c937f9f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
dynamic-lookup-of-block-source
branch
2 times, most recently
from
3b93c99 to
29299d2
Compare
When a user chooses to dispute a block, we now dynamically lookup the source of the block instead of getting the dispute URL from the query parameters. This is in preparation for an extension update that will necessitate dropping the `newIssueUrl` query parameter we had previously been relying on. This is a temporary measure. A future update will restore the source for each block. At that time we can revert this change. This should be comparing in exactly the same way as the extension. The configuration is fetched dynamically so it may be slightly more up-to-date than what the extension is using.
Gudahtt
force-pushed
the
dynamic-lookup-of-block-source
branch
from
29299d2 to
747bb04
Compare
|
Now that the Playwright tests have been merged, this PR has been updated with proper test coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user chooses to dispute a block, we now dynamically lookup the source of the block instead of getting the dispute URL from the query parameters. This is in preparation for an extension update that will necessitate dropping the
newIssueUrlquery parameter we had previously been relying on.This is a temporary measure. A future update will restore the source for each block. At that time we can revert this change.
This should be comparing in exactly the same way as the extension. The configuration is fetched dynamically so it may be slightly more up-to-date than what the extension is using.