Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename initProvider to initializeProvider #114

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Rename initProvider to initializeProvider #114

merged 2 commits into from
Nov 30, 2020
+12 −12

Conversation

rekmarks
Copy link
Member

This is purely cosmetic. Renames all strings and files named "initProvider" to "initializeProvider".

Down with useless contractions.

@rekmarks rekmarks requested a review from a team as a code owner November 30, 2020 17:54
@rekmarks rekmarks requested a review from danjm November 30, 2020 17:54
Gudahtt
Gudahtt approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... since there are going to be breaking changes anyway... why not!

@rekmarks
Copy link
Member Author

CI passes: https://app.circleci.com/pipelines/github/MetaMask/inpage-provider/371/workflows/a4c9d538-7207-42c1-abe7-2c468ccbc287

@rekmarks rekmarks merged commit 55784a7 into main Nov 30, 2020
@rekmarks rekmarks deleted the initialize-provider branch November 30, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @Gudahtt