Support Flask and Beta in the external extension provider #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
reviewed
Apr 19, 2023
Mrtenz
reviewed
Apr 19, 2023
Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
approved these changes
Apr 20, 2023
| @@ -8,14 +8,16 @@ import config from './external-extension-config.json'; | |||
|
|
|||
| const browser = detect(); | |||
|
|
|||
| export function createExternalExtensionProvider() { | |||
| export type ExtensionType = 'stable' | 'flask' | 'beta' | string; | |||
There was a problem hiding this comment.
Does this actually provide autocomplete, since ExtensionType is inferred as just string?
There was a problem hiding this comment.
It does not. Do you have an idea of how to make that happen?
There was a problem hiding this comment.
Probably not possible unless the ID is not a string.
export type ExtensionType = 'stable' | 'flask' | 'beta' | `id:${string}`;This works for example, but not sure if that's what we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Flask, Beta and custom extension IDs in the external extension provider.
Fixes #251