Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository to match module template (February 2024) #133

Merged
merged 6 commits into from
Feb 21, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Feb 21, 2024

This updates the repository to match the modulate template as of February 2024. This includes:

  • Changing the build system to tsup, which adds a ESM version.
  • Better linting with constraints.
  • Updated CI to only run on the necessary Node.js versions.

I've also updated @metamask/utils to use the better ESM version. These changes will help Snaps to reduce the size.

@Mrtenz Mrtenz requested a review from a team as a code owner February 21, 2024 14:41
Copy link

socket-security bot commented Feb 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@cspotcode/[email protected] filesystem +3 293 kB cspotcode
npm/@esbuild/[email protected] None 0 11.5 MB evanw
npm/@esbuild/[email protected] None 0 9.83 MB evanw
npm/@esbuild/[email protected] None 0 11.5 MB evanw
npm/@esbuild/[email protected] None 0 9.76 MB evanw
npm/@esbuild/[email protected] None 0 10.2 MB evanw
npm/@esbuild/[email protected] None 0 8.85 MB evanw
npm/@esbuild/[email protected] None 0 9.61 MB evanw
npm/@esbuild/[email protected] None 0 9.18 MB evanw
npm/@esbuild/[email protected] None 0 8.85 MB evanw
npm/@esbuild/[email protected] None 0 9.14 MB evanw
npm/@esbuild/[email protected] None 0 9.37 MB evanw
npm/@esbuild/[email protected] None 0 10.4 MB evanw
npm/@esbuild/[email protected] None 0 9.18 MB evanw
npm/@esbuild/[email protected] None 0 9.11 MB evanw
npm/@esbuild/[email protected] None 0 10 MB evanw
npm/@esbuild/[email protected] None 0 9.6 MB evanw
npm/@esbuild/[email protected] None 0 9.59 MB evanw
npm/@esbuild/[email protected] None 0 9.62 MB evanw
npm/@esbuild/[email protected] None 0 9.59 MB evanw
npm/@esbuild/[email protected] None 0 8.98 MB evanw
npm/@esbuild/[email protected] None 0 9.45 MB evanw
npm/@esbuild/[email protected] None 0 9.81 MB evanw
npm/@lavamoat/[email protected] filesystem Transitive: environment +6 249 kB naugtur
npm/@lavamoat/[email protected] environment, filesystem, shell Transitive: network +124 8.06 MB boneskull
npm/@lavamoat/[email protected] None 0 3.25 kB naugtur
npm/@npmcli/[email protected] environment, network +11 1.15 MB npm-cli-ops
npm/@npmcli/[email protected] filesystem +2 136 kB lukekarrys
npm/@npmcli/[email protected] filesystem Transitive: environment, shell +18 804 kB npm-cli-ops
npm/@npmcli/[email protected] filesystem Transitive: environment, shell +56 3.43 MB npm-cli-ops
npm/@npmcli/[email protected] environment, shell Transitive: filesystem +2 62.5 kB npm-cli-ops
npm/@npmcli/[email protected] environment Transitive: filesystem, network, shell +106 7.21 MB npm-cli-ops
npm/@tsconfig/[email protected] None 0 2.39 kB typescript-deploys
npm/@tsconfig/[email protected] None 0 2.5 kB typescript-deploys
npm/@tsconfig/[email protected] None 0 2.39 kB typescript-deploys
npm/@tsconfig/[email protected] None 0 2.45 kB typescript-deploys
npm/[email protected] None 0 4.83 kB lukekarrys
npm/[email protected] None 0 52.4 kB marijn
npm/[email protected] network +1 30.3 kB tootallnate
npm/[email protected] network Transitive: environment, eval +3 79.8 kB fengmk2
npm/[email protected] None 0 22.2 kB kevinbeaty
npm/[email protected] None 0 12.9 kB qix
npm/[email protected] filesystem +6 142 kB npm-cli-ops
npm/[email protected] None 0 5.36 kB sindresorhus
npm/[email protected] environment, filesystem, unsafe Transitive: network, shell +24 213 MB egoist
npm/[email protected] None 0 81.8 kB egoist
npm/[email protected] filesystem Transitive: environment, shell +51 3.53 MB npm-cli-ops
npm/[email protected] environment, filesystem +13 519 kB paulmillr
npm/[email protected] filesystem, unsafe 0 6.25 kB pi0
npm/[email protected] environment, filesystem, network, shell +22 213 MB evanw
npm/[email protected] filesystem +1 299 kB npm-cli-ops
npm/[email protected] Transitive: environment, filesystem, shell +27 2.86 MB isaacs
npm/[email protected] None +1 485 kB npm-cli-ops
npm/[email protected] network +2 53.7 kB tootallnate
npm/[email protected] network +2 65.6 kB tootallnate
npm/[email protected] None +1 8.43 kB sindresorhus
npm/[email protected] environment +13 574 kB isaacs
npm/[email protected] environment, filesystem 0 14 kB egoist
npm/[email protected] filesystem 0 17.7 kB antonk52
npm/[email protected] None 0 17.1 kB egoist
npm/[email protected] None 0 75.8 kB jdalton
npm/[email protected] network Transitive: environment, filesystem, shell +74 4.97 MB npm-cli-ops
npm/[email protected] None +1 290 kB isaacs
npm/[email protected] environment, network +6 871 kB npm-cli-ops
npm/[email protected] filesystem, network, shell +4 52 kB jongleberry
npm/[email protected] environment, shell Transitive: filesystem, network +83 6.85 MB lukekarrys
npm/[email protected] None +1 31 kB npm-cli-ops
npm/[email protected] None +12 763 kB npm-cli-ops
npm/[email protected] None +2 116 kB npm-cli-ops
npm/[email protected] None +7 630 kB npm-cli-ops
npm/[email protected] None +10 657 kB npm-cli-ops
npm/[email protected] None 0 5.49 kB sindresorhus
npm/[email protected] environment, unsafe Transitive: filesystem +25 73.5 MB ai
npm/[email protected] None 0 5.21 kB lukekarrys
npm/[email protected] environment, filesystem +1 2.43 MB lukastaegert
npm/[email protected] network +7 612 kB tootallnate
npm/[email protected] None +3 51.4 kB kemitchell
npm/[email protected] None +1 323 kB npm-cli-ops
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +42 4.59 MB alangpierce
npm/[email protected] None +2 36.7 kB dead_horse
npm/[email protected] None +1 30.1 kB dead_horse
npm/[email protected] None +1 356 kB sebmaster
npm/[email protected] shell 0 7.82 kB wmhilton
npm/[email protected] None 0 68 kB dsagal2
npm/[email protected] environment, filesystem, unsafe +18 72.4 MB blakeembrey
npm/[email protected] environment, eval, filesystem Transitive: network, shell, unsafe +144 296 MB egoist
npm/[email protected] None +2 17.9 kB lukekarrys
npm/[email protected] None +1 14.5 kB lukekarrys
npm/[email protected] environment, filesystem, unsafe 0 18.2 kB cspotcode
npm/[email protected] None +4 68 kB kemitchell
npm/[email protected] None +3 122 kB lukekarrys
npm/[email protected] None 0 19.3 kB domenic
npm/[email protected] None +4 529 kB domenic
npm/[email protected] environment Transitive: filesystem +1 50.5 kB npm-cli-ops
npm/[email protected] None 0 6.31 kB sindresorhus

🚮 Removed packages: npm/@lavamoat/[email protected], npm/@lavamoat/[email protected], npm/@lavamoat/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Feb 21, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Network access npm/[email protected]
Network access npm/[email protected]
Shell access npm/[email protected]
Network access npm/[email protected]
New author npm/[email protected]
Shell access npm/[email protected]
New author npm/[email protected]
New author npm/[email protected]
New author npm/[email protected]
New author npm/[email protected]
Network access npm/[email protected]
Deprecated npm/[email protected]
  • Reason: Breaking node 16
Install scripts npm/[email protected]
Shell access npm/[email protected]
Network access npm/[email protected]
Network access npm/[email protected]
Network access npm/@npmcli/[email protected]
Network access npm/@npmcli/[email protected]
Network access npm/@npmcli/[email protected]
Network access npm/@npmcli/[email protected]
Network access npm/@npmcli/[email protected]

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!

@Mrtenz Mrtenz merged commit 9fcba7a into main Feb 21, 2024
15 of 16 checks passed
@Mrtenz Mrtenz deleted the mrtenz/standardise-february-2024 branch February 21, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants