Rename exports to be more generic #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
force-pushed
the
mrtenz/rename-exports
branch
from
d1c8ffc to
956c72e
Compare
…aming This commit updates comments in the README file to make it clear that JSON-RPC errors and Ethereum EIP-1474 errors are under the 'rpcErrors' namespace, and adds that Ethereum EIP-1193 Provider errors are now under the 'providerErrors' namespace.
The providerErrors was not exported from the index.ts file, so it was imported separately from the errors module. This commit includes the export statement for providerErrors in the index.ts file.
Adjusting the coverage thresholds to meet the new requirements.
FrederikBolding
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethErrors.rpcis now exported asrpcErrors.ethErrors.provideris now exported asproviderErrors. This is still Ethereum-specific.(Serialized)EthereumRpcErroris now(Serialized)JsonRpcError.eth-rpc-errorshave been updated torpc-errors.This is technically a breaking change, but we will be publishing this package under a new name.