feat: AccountSelector
#3088
Draft
feat: AccountSelector
#3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
GuillaumeRx
force-pushed
the
gr/account-selector
branch
from
c5fe4c3 to
ee67e9e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3088 +/- ##
==========================================
+ Coverage 94.88% 94.90% +0.01%
==========================================
Files 506 508 +2
Lines 11123 11162 +39
Branches 1709 1717 +8
==========================================
+ Hits 10554 10593 +39
Misses 569 569 ☔ View full report in Codecov by Sentry. |
GuillaumeRx
force-pushed
the
gr/account-selector
branch
from
311858f to
b32f31a
Compare
GuillaumeRx
commented
Feb 12, 2025
Mrtenz
requested changes
Feb 13, 2025
packages/snaps-sdk/src/jsx/components/form/AccountSelector.test.tsx
Outdated
Show resolved
Hide resolved
packages/snaps-sdk/src/jsx/components/form/AccountSelector.test.tsx
Outdated
Show resolved
Hide resolved
| { | ||
| name: string(), | ||
| hideExternalAccounts: optional(boolean()), | ||
| chainIds: optional(array(CaipChainIdStruct)) as unknown as Struct< |
GuillaumeRx
force-pushed
the
gr/account-selector
branch
from
0f3aca9 to
23230f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new component called
AccountSelector.This component uses the account list of the client to display and select an account. The list can be filtered via the component props.
Progresses: #2810