Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding opBnB chain #335

Merged
merged 5 commits into from
Jun 14, 2024
Merged

chore: adding opBnB chain #335

merged 5 commits into from
Jun 14, 2024

Conversation

pnarayanaswamy
Copy link
Contributor

No description provided.

@pnarayanaswamy pnarayanaswamy marked this pull request as ready for review June 14, 2024 08:30
@pnarayanaswamy pnarayanaswamy changed the title chore: adding opBnB chain and sign typed data v1 chore: adding opBnB chain Jun 14, 2024
seaona
seaona approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The network is now supported and the contracts ERC20 and ERC721 seem to work fine too

opbnb-test-dapp.mp4

@pnarayanaswamy pnarayanaswamy merged commit 57142ca into main Jun 14, 2024
7 checks passed
@pnarayanaswamy pnarayanaswamy deleted the add-bnb-chain branch June 14, 2024 12:02
@vinistevam vinistevam mentioned this pull request Jun 14, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Aug 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaona seaona seaona approved these changes

@Mshn61 Mshn61 Mshn61 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnarayanaswamy @seaona @Mshn61