-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite dbt cloud crawler using discovery API #1052
Rewrite dbt cloud crawler using discovery API #1052
Conversation
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
==========================================
+ Coverage 89.54% 89.58% +0.04%
==========================================
Files 211 210 -1
Lines 13525 13525
==========================================
+ Hits 12111 12117 +6
+ Misses 1414 1408 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks for the refactoring.
🤔 Why?
Should use the dbt discovery API
environment
endpoint to fetch most of the metadata instead ofjobs
. This simplifies the steps and has more complete lineage info.🤓 What?
environment
endpoint, as well as the admin API to get all projects and environmentsjob_ids
no longer used🧪 Tested?
Tested against metaphor dbt instance. File diff with MCE generated using previous crawlers. The results are mostly the same.
dbtModel.sourceModels
not longer filled as it's an deprecated field in favor ofentityUpstream
https://cloud.getdbt.com/accounts/123/jobs/146/docs/#!/xxx
no longer supported by dbttest.sql
not available currently, can get it from top-levelenvironment.tests
endpoint later onformula
is now available.☑️ Checks
pyproject.toml
.