Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column stats to unity catalog profiler #719

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

It is also possible to get column stats from databricks sql client, best if we can support that.

🤓 What?

Parses column stats with databricks sql client, and stores the info in Dataset.field_statistics.

🧪 Tested?

Tested locally.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

This pull request has been linked to Shortcut Story #22812: Add column stats to Unity Catalog profiler.

Copy link

github-actions bot commented Dec 8, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
14257 13030 91% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/unity_catalog/profile/extractor.py 94% 🟢
TOTAL 94% 🟢

updated for commit: 5c485f9 by action🐍

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9999ffb) 91.19% compared to head (5c485f9) 91.39%.

Files Patch % Lines
metaphor/unity_catalog/profile/extractor.py 97.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
+ Coverage   91.19%   91.39%   +0.20%     
==========================================
  Files         169      135      -34     
  Lines       14371    14257     -114     
==========================================
- Hits        13105    13030      -75     
+ Misses       1266     1227      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usefulalgorithm usefulalgorithm enabled auto-merge (squash) December 8, 2023 05:38
Copy link
Contributor

@elic-eon elic-eon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Go

@usefulalgorithm usefulalgorithm merged commit 091ddb2 into main Dec 8, 2023
6 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-22812/add-column-stats-to-unity-catalog-profiler branch December 8, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants