Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autopublishing SweetAlert #1

Closed
dandv opened this issue Jun 11, 2015 · 11 comments
Closed

Autopublishing SweetAlert #1

dandv opened this issue Jun 11, 2015 · 11 comments

Comments

@dandv
Copy link
Contributor

dandv commented Jun 11, 2015

Hey @ecwyne and @kevohagan,

Would you like to work together to keep SweetAlert up-to-date using http://autopublish.meteor.com?

I see that https://github.com/kevohagan/meteor-sweetalert was updated 2 days ago.

@ecwyne wanted to help autopublish the wrapper - see MeteorPackaging/discussions#29

Goals:

  • Use autopublish
  • Use the "sister-repo" approach; @kevohagan already includes the upstream as a submodule rather than forking it - great
  • Have only one authoritative SweetAlert package on Atmosphere

Namespacing-wise, I've created https://atmospherejs.com/sweetalert and added both of you, but kevohagan:sweetalert already has a lot of traction on Atmosphere and

  • until MDG implements renaming packages, we're probably better off keeping the existing naming
  • on the other hand, the official twbs:boostrap easily overtook @mizzao's bootstrap package in popularity, with his graceful collaboration
@splendido
Copy link
Member

jspdf-core-wrapper might be the repo to look at and copy paste files from it for a quick start! :-)

@kevohagan
Copy link
Contributor

yes im totally up for this @dandv @ecwyne @splendido !

@kevohagan
Copy link
Contributor

@dandv how to i go about doing the "sister-repo" aproach?

@splendido
Copy link
Member

@kevohagan I've just seen you already moved your repo to MeteorPackaging.

For the 'sister repo' approach, lets have a look at jspdf-core-wrapper: you basically have to copy/paste:

  • gulpfile.js
  • package.json
  • autopublish.json (to be edited...)

and update the package.js to have file paths referring to an upstream folder:

    api.add_files([
        'upstream/lib/sweet-alert.css',
        'upstream/lib/sweet-alert.min.js'
    ], ['client']);

this is because with gulp getUpstream a clone of the official repo will be made under the upstream folder.
This way you can get rid of the submodule and be able to checkout whichever version you need.

Whatmore, I'm finishing the integration for this new approach right now, so that we can start testing it out.

The only missing thing to finish the process automation would be asking t4t5 to create a webhook for us...

@splendido
Copy link
Member

See this comment for some instructions...

@ecwyne
Copy link
Contributor

ecwyne commented Jun 23, 2015

(sorry guys, I was out of town for a week)

@splendido I've updated the repo per your comment (1f05196)

@ecwyne
Copy link
Contributor

ecwyne commented Jun 23, 2015

Whatmore, I'm finishing the integration for this new approach right now, so that we can start testing it out.

Is there anything else we need to do before this testing can begin?

@splendido
Copy link
Member

I've also been out for more than a month...
I hope to be able to get back to autopublish.meteor.com soon

For now I'd say we'll have to keep it updated by hands.
Could you please try to publish the new release by hands?

There are still a couple fo things to be done though:

  • update package name (sweetalert:sweetalert? or what?)
  • update package summary to mention this is the official wrapper
  • add some tests (at least some minimum tests like these to check swal is correctly exported...)

After this, the command sequence to publish a new version would be something like:

  • git clone https://github.com/MeteorPackaging/SweetAlert.git
  • cd SweetAlert
  • npm install
  • gulp getUpstream --tag v1.1.0
  • gult test

and then, only in case tests pass:

  • gulp updateVersion
  • gulp updateRelease --tag v1.1.0
  • git commit -am 'Bump to version 1.1.0
  • git push
  • meteor publish (meteor publish --create for this first time...)

@splendido
Copy link
Member

Also, please consider to add another couple of files to correctly export swal...
See these lines

@splendido
Copy link
Member

Let us know when you're ready to publish, just for a final check ;-)

@ecwyne
Copy link
Contributor

ecwyne commented Dec 19, 2017

This can probably be closed :)

@dandv dandv closed this as completed Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants