Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change multi JWK Set min from 2 to 1 #88

Merged
merged 1 commit into from
May 13, 2023
Merged

Conversation

MicahParks
Copy link
Owner

The purpose of this pull request is to change the MultipleJWKS creation minimum required JWK Sets from 2 to 1.

This is because it's convenient to use the Multi JWK Set implementation in scenarios where one or more JWK Set is required.

Closes: #87

@MicahParks MicahParks marked this pull request as ready for review May 13, 2023 22:18
@MicahParks MicahParks merged commit 770093f into master May 13, 2023
@MicahParks MicahParks deleted the change_multi_min branch May 13, 2023 22:18
@WayneWuQSR
Copy link

Hi @MicahParks. I have noticed a comment related to this change on the following lines:

  1. var ErrMultipleJWKSSize = errors.New("multiple JWKS must have two or more remote JWK Set resources")
  2. // GetMultiple creates a new MultipleJWKS. A map of length two or more JWKS URLs to Options is required.

    which still indicate the minimum jwk sets to is 2.

@MicahParks
Copy link
Owner Author

Thanks. I'll change that tonight.

@MicahParks
Copy link
Owner Author

@WayneWuQSR please find the corrected comment and error text in v2.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Why is there an ErrMultipleJWKSSize Error
2 participants